-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scrolling of string_input_popup descriptions #58609
Allow scrolling of string_input_popup descriptions #58609
Conversation
Thank you Qrox for the review. I'm sorry there were so many mistakes to find. I believe the latest commits should address all of your comments. |
Summary
Interface "Allow scrolling of string_input_popup descriptions"
Purpose of change
When creating a string_input_popup window, there is no error-checking to ensure that the window will fit on the screen. So, for string_input_popups with complicated description information (notably the crafting filter
&
->/
), the window will fail to display on small screens. In certain circumstances, this can go on to cause other display problems.Fixes #48700
Fixes #52688
Describe the solution
PPAGE
/NPAGE
, scrolled withMousewheel
), allowing descriptions of arbitrary lengthDescribe alternatives you've considered
Could cause problems with translation
Not really a long-term solution
Testing
New screenshots/videos 2022-06-23:
Crafting filter in English at various sizes
Crafting filter in various non-English languages (Polish pictured) at various sizes
Simple string input popup that fits on one line
Simple string input popup that has title and input on different lines
Simple string input popup where the title folds to a second line
(Yes, it folds like that before this too)
Keybindings menu (string_input_popup with custom window)
String input popup with displayed history
Scrolling behaviour with mouse and page up/page down (Russian)
Mousewheel_scrolling--Crafting_filter--Russian-v2.mp4
Resizing behaviour - popup without description (Polish)
Resizing_behaviour--Character_name_change--Polish.mp4
Resizing behaviour - Crafting filter
Resizing_behaviour--Crafting_filter.mp4
Additional context